Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 14543 std.algorithm.searching.until does not handle range sentinels nicely #8568

Closed
wants to merge 10 commits into from
Closed

Conversation

jamesragray
Copy link

Implemented: https://issues.dlang.org/show_bug.cgi?id=14543
This is somewhere between a bug fix and a new feature because you could argue the old behaviour is wrong.

@dlang-bot
Copy link
Contributor

dlang-bot commented Sep 14, 2022

Thanks for your pull request and interest in making D better, @jamesragray! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
14543 normal std.algorithm.searching.until does not handle range sentinels nicely

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8568"

std/algorithm/searching.d Outdated Show resolved Hide resolved
std/algorithm/searching.d Outdated Show resolved Hide resolved
std/algorithm/searching.d Outdated Show resolved Hide resolved
std/algorithm/searching.d Outdated Show resolved Hide resolved
std/algorithm/searching.d Outdated Show resolved Hide resolved
@thewilsonator thewilsonator changed the title First commit of fixing https://issues.dlang.org/show_bug.cgi?id=14543 Issue 14543 std.algorithm.searching.until does not handle range sentinels nicely Sep 15, 2022
@thewilsonator
Copy link
Contributor

BTW if you think this PR fixes the issue, make sure the title of (one of) the commit's message starts with Fix issue 14543: followed by the title of the issue.

@pbackus
Copy link
Contributor

pbackus commented Sep 16, 2022

Might be worth submitting a draft PR that just changes OpenRight.no to include the full sentinel, and see if any of the projects tested on Buildkite break. If we can get away with it, that would be a much cleaner solution.

cc @atilaneves, this introduces a new public symbol.

@jamesragray
Copy link
Author

jamesragray commented Sep 16, 2022

I have done that here: #8570

@jamesragray
Copy link
Author

The problem has been fixed here #8570

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants