Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 16942: slide!(No.withPartial): Correctly handle first slide exhausting input range. #8738

Merged

Conversation

FeepingCreature
Copy link
Contributor

Apply the suggested change from https://issues.dlang.org/show_bug.cgi?id=19642

@dlang-bot
Copy link
Contributor

dlang-bot commented Apr 20, 2023

Thanks for your pull request and interest in making D better, @FeepingCreature! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19642 normal std.range.slide!(No.withPartial) on lengthless forward range: get empty when expecting one window

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8738"

@RazvanN7 RazvanN7 merged commit 8a9cfa2 into dlang:master Apr 24, 2023
14 checks passed
@FeepingCreature FeepingCreature deleted the fix/issue-19642-unbreak-slide branch April 24, 2023 10:14
@quickfur
Copy link
Member

This PR caused a regression: https://issues.dlang.org/show_bug.cgi?id=23976

@FeepingCreature
Copy link
Contributor Author

Thanks! I'll have a look tomorrow.

@FeepingCreature
Copy link
Contributor Author

Please see discussion at https://forum.dlang.org/post/ivmrolypalfsoqeqecki@forum.dlang.org : the specified behavior of slide is confusing and contradictory, and I don't understand what it's supposed to do, and when.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants