Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Travis CI setup -> compile all executable #205

Closed
wants to merge 6 commits into from

Conversation

wilzbach
Copy link
Member

As I wanted to enable a Travis CI compilation check for #203, I realized that further cleanup needs to be done. Thus here are the Travis CI enhancements - the commit messages should be explanatory.

I removed digger in favor of custom cloning as the posix.mak requires the typical dlang structure.

@CyberShadow
Copy link
Member

I removed digger in favor of custom cloning as the posix.mak requires the typical dlang structure.

Sorry, what was the problem? Digger invokes the Tools makefile just fine (use --with=tools).

@wilzbach
Copy link
Member Author

Sorry, what was the problem? Digger invokes the Tools makefile just fine (use --with=tools).

Yes, but we need to pass in a custom list of scripts to be build a la make -f posix.mak dget tolf (as changed.d is broken atm). Also cloning the repos manually creates more similarity with the other build scripts.

@CyberShadow
Copy link
Member

Also cloning the repos manually creates more similarity with the other build scripts.

What is the effective difference between Digger's repository layout and the one done here?

@MartinNowak
Copy link
Member

Looks sensible

What is the effective difference between Digger's repository layout and the one done here?

For example the shell script builds pull requests against the correct base branch, e.g. stable or feature branches.
Also cloning digger and it's dependencies, plus relying on the bitbucket repo adds a lot of failure points to a CI system, just to replace a snippet of shell script. And effectively errors would be harder to understand for anyone not familiar with Digger's architecture.

install_digger() {
$DIGGER build --model=$MODEL "master"
export PATH=$PWD/result/bin:$PATH
make -j$N -C ../dmd/src -f posix.mak MODEL=$MODEL HOST_DMD=dmd all
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing make -j$N -C src -f posix.mak MODEL=$MODEL HOST_DMD=$DMD dmd.conf after that, hence the failure with rdmd.

@wilzbach wilzbach added the PR.Blocked A PR blocker by another issue / PR, external to the PR (as opposed to WIP) label Mar 5, 2017
@wilzbach wilzbach mentioned this pull request Jun 15, 2017
@wilzbach
Copy link
Member Author

Superseded by #233

@wilzbach wilzbach closed this Jun 15, 2017
@wilzbach wilzbach deleted the improve-travis branch July 3, 2017 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR.Blocked A PR blocker by another issue / PR, external to the PR (as opposed to WIP)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants