Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meson: add meson build #33

Closed
wants to merge 1 commit into from
Closed

Meson: add meson build #33

wants to merge 1 commit into from

Conversation

pjotrp
Copy link
Contributor

@pjotrp pjotrp commented Oct 29, 2018

With dub this will create a static library which can be found by other meson based builds. This is authored by Debian (thanks @tillea) and we ought to have it in upstream. Later versions of meson can include main automatically, but this should work with older meson versions too. We should upgrade later. See also https://mesonbuild.com/D.html#using-embedded-unittests

@wilzbach
Copy link
Member

Have a look at #20

@pjotrp
Copy link
Contributor Author

pjotrp commented Oct 29, 2018

@wilzbach tests pass on this one. @ximion obviously wrote it. I think we can merge this PR since it does not conflict with other build systems and will make the Debian people happy. #20 was already approved (apparently).

@wilzbach
Copy link
Member

@wilzbach tests pass on this one. @ximion obviously wrote it. I think we can merge this PR since it does not conflict with other build systems and will make the Debian people happy. #20 was already approved (apparently).

Uhm I think the discussion at #20 never finished / got to a consensus.

pjotrp pushed a commit to pjotrp/BioD that referenced this pull request Oct 29, 2018
@pjotrp
Copy link
Contributor Author

pjotrp commented Oct 29, 2018

meson got dub support (recently). And dub may do meson.The question was apparently whether the meson.build file belongs in the source tree or not. As meson is a build system which can be used like cmake and autotools there is really no reason not to include it as it is beneficial to all distributions (if they choose to use it). I can see I'll use it in GNU Guix once it is there.

In short, the Debian people (and I) will maintain the meson file and it does not hurt anything else. So, unless someone thinks meson is evil or we should remove unDead altogether, I think it belongs here.

@pjotrp
Copy link
Contributor Author

pjotrp commented Oct 29, 2018

I'll add that I think we should be distribution friendly. With ldc and gdc going main stream we can only support their efforts. It is bad enough that things break between compiler versions - mostly controlled through deprecations, but still a maintenance burden.

@pjotrp
Copy link
Contributor Author

pjotrp commented Mar 16, 2019

We moved relevant unDead files into BioD so we can move forward. In time we'll get rid of them. Sambamba nor BioD depends on this repo now.

@pjotrp pjotrp closed this Mar 16, 2019
@tillea
Copy link

tillea commented Mar 16, 2019 via email

@pjotrp
Copy link
Contributor Author

pjotrp commented Mar 16, 2019

Yes, if BioD/sambamba is the only one using the current unDead package in Debian I would remove it.

@ximion
Copy link

ximion commented Mar 16, 2019

+1 from me for just removing it from Debian. UndeaD was always a bit awkward to have anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants