-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ip assign feature with requested changes #59
Conversation
Reran black and isort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will work fine. Ideally the code to parse & edit the raw JSON would move to pykumo, but that can be done later so this gets into people's hands who need it. I'll merge this and push a beta version once I've done some local testing.
That sounds like a challenge...not sure how you would like pykumo to request the input from the user and then store it? Would there be a separate file just for IP addresses? |
Bump manifest version
KumoCloudAccount has the raw JSON, held in memory in a member variable. My thought is to provide two new methods on KumoCloudAccount: Anyway, no need to do this now, but I anticipate getting called out in HA code review for this: it's something the pykumo library really should be responsible for. |
Aha, that makes sense. I'll see if I can put something together when I get back from vacation... Doesn't sound too complicated... |
I'm not sure what happened with this pull request, but when I look at the commits, I do not see the merge indicating the branch relationship correctly. I see it as just hanging off master still: |
Ah, I did squash-and-merge to keep master's revision history clean. We should delete the feature branch. |
Sound good, done. Thanks. |
This should include all the changes that @danielgoepp made to formatting as well as the requested changes to include "grandchildren".
The last unresolved comment is still "...and here, and in the next loop. It may be worth a pair of utility functions to get / set the IPs for all the units" . I am not sure what you meant by this?