Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NamedQuery parameters should be optional #870

Closed
donaldgray opened this issue Jun 26, 2024 · 0 comments · Fixed by #872
Closed

NamedQuery parameters should be optional #870

donaldgray opened this issue Jun 26, 2024 · 0 comments · Fixed by #872
Assignees
Labels
bug Something isn't working orchestrator

Comments

@donaldgray
Copy link
Member

There has been a change in behaviour between how Deliverator and Protagonist handles NamedQuery parameters.

Deliverator allows you to specify multiple parameters in an NQ definition and only supply some of them, the others would effectively be ignored. However, this was tightened up in Protagonist and parameters became required - e.g. if an NQ is configured with 3 p* values but was only given 1 it will return a 400 exception, logging an error of Not enough query arguments to satisfy template element parameter.

Protagonist should allow missing parameters, a follow up ticket with introduce a new syntax to specify required parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working orchestrator
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants