TimeScaleView - ability to adjust style of labels

[PSI-Polska-ASM]

Hello Dirk,
our client has a new requirement: ability to adjust style of labels in TimeScaleView.

We think that following solution would be sufficient for us:

Modifications in method impl.com.calendarfx.view.TimeScaleViewSkin#layoutChildrenInfiniteScrolling:

            if (midnight) {
                label.setText(LocalDate.ofInstant(time, view.getZoneId()).format(getSkinnable().getDateFormatter()));
                label.setStyle(getSkinnable().getDateStyleProvider().getStyle(time));
            } else {
                label.setText(ZonedDateTime.ofInstant(time, view.getZoneId()).toLocalTime().format(getSkinnable().getTimeFormatter()));
                label.setStyle(getSkinnable().getTimeStyleProvider().getStyle(time));
            }

Modifications in class TimeScaleView:

    public interface TimeScaleStyleProvider {
        default String getStyle(Instant time) {
            return null;
        }
    }
    
    private static class DefaultTimeScaleStyleProvider implements TimeScaleStyleProvider {}
    
    private final ObjectProperty<TimeScaleStyleProvider> timeStyleProvider = new SimpleObjectProperty<>(this, "timeStyleProvider", new DefaultTimeScaleStyleProvider());
    private final ObjectProperty<TimeScaleStyleProvider> dateStyleProvider = new SimpleObjectProperty<>(this, "dateStyleProvider", new DefaultTimeScaleStyleProvider());
    
    public TimeScaleStyleProvider getTimeStyleProvider() {
        return timeStyleProvider.get();
    }
    public ObjectProperty<TimeScaleStyleProvider> timeStyleProviderProperty() {
        return timeStyleProvider;
    }
    public TimeScaleStyleProvider getDateStyleProvider() {
        return dateStyleProvider.get();
    }
    public ObjectProperty<TimeScaleStyleProvider> dateStyleProviderProperty() {
        return dateStyleProvider;
    }

What do you think about the idea? Or maybe do you have any other ideas for achieving that? Would you be interested to introduce these changes directly in the CalendarFX?

[dlemmermann]

Why not add a style class for each time label in the existing code? Then you can use those style classes for styling them based on semantics. E.g. add the styles "midnight" and "noon" and also add the time as a style class to all the other times: "time00", "time01", etc ..... midnight would have "midnight" and "time24" and "time00".

[PSI-Polska-ASM]

It is a very nice idea, but we will need also information about what date is actually related to given label.

We are 100% sure that we will need to know which day of the week it is (e.g. Sunday), but our users probably will want more - like maybe holidays or some dates defined by the user during runtime of the application. Users might also want to define their colors, instead of using predefined ones. With style providers we would be able to define style on the fly, basing on users configuration and time and date of the label.

But maybe it would be possible to extend your idea with style classes a little bit more - maybe a class style provider for given time/date entry? We will be very grateful for all your suggestions.

[dlemmermann]

So where would this stop? Do you also want to color the grid lines differently?

[PSI-Polska-ASM]

I apologize if my answer has upset you, I only wanted to present our reasoning. We only need what I have described earlier - the ability to style the labels of TimeScaleView, depending on the related time and date.

Would you be able to help us? Would it be possible to extend functionality of the CalendarFX to achieve that (like in provided by us code)?

[dlemmermann]

I wasn't upset :-) Just curious how far we need to take this? Please provide a pull request and I will merge it in.

[PSI-Polska-ASM]

That's good to hear, I wasn't sure. Thank you. We will prepare a pull request soon.

[dlemmermann]

Closing this issue due to inactivity.