Fixed issues regarding the Drag and Drop of the entry at the start and end of it #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to 8.5.0
…d end of it: - Wierd behavior when the Start of the entry is dragged after the end and then go back as before start date. - Fix behavior when the cursor is out of the dayView, now only affects the Time on the date that the entry is currently positioned.
Handler for mouse clicking and PerformSelection method were moved to EntryViewBase class. After debuggin this handler, it seems to be called multiple times while clicking anywhere inside the view and of course it happens due to each control that shapes the entire view has this handler, causing that clicked entry get added and removed from the Selection list over and over again. This situation was preventing that Multi-selection works correctly in the day page, but having that logic in the EntryViewBase class, it give us the expected performance.
Logic inside performSelection method was reverted a little bit in order to support the normal click (not multi-select) over entries that are actually selected instead of deselect the other ones.
|
Can you do me a favor and create issues / tickets for the bugs you fixed? Ideally one starts with a ticket first and then the same person or somebody else provides a pull request with a fix. The video you included was a great help, but the other issues you mention I have no idea what you mean there. |
arias9306
added a commit
to arias9306/CalendarFX-TeamA1
that referenced
this pull request
Sep 12, 2018
Merge pull request dlsc-software-consulting-gmbh#37 from arias9306/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request required to fix the following issues and also code refactoring: