Added solarize to MagickImage #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlemstra
reviewed
Jun 26, 2023
src/magick-image.ts
Outdated
| @@ -247,6 +247,8 @@ export interface IMagickImage extends IDisposable { | |||
| sigmoidalContrast(contrast: number, midpoint: number): void; | |||
| sigmoidalContrast(contrast: number, midpoint: number, channels: Channels): void; | |||
| splice(geometry: MagickGeometry): void; | |||
| solarize(): void; | |||
| solarize(factor: Percentage | number): void; | |||
There was a problem hiding this comment.
In the interface I don't use | but write both overloads instead.
solarize(factor: number): void;
solarize(factor: Percentage): void;
src/magick-image.ts
Outdated
| @@ -1328,6 +1330,14 @@ export class MagickImage extends NativeInstance implements IMagickImage { | |||
| this._sigmoidalContrast(true, contrast, midpointOrPercentage, channelsOrUndefined) | |||
| } | |||
|
|
|||
| solarize(): void | |||
| solarize(factorOrNumber: Percentage | number = new Percentage(50)): void { | |||
There was a problem hiding this comment.
Can you change factorOrNumber to numberOrPercentage? And I like the use of = new Percentage(50). Think I should have used that in some other spots also.
…solarize method in MagickImage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.