Make package type module #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your help. Normally I would want to have this in separate pull requests but thanks for splitting this up in separate commits. Could you amend the "Make package type module" commit and include that "Fix deno import" commit so we have a nice clean history? |
|
Like this? |
|
Yup, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit Make package type module sets the
package.jsontotype: "module", and makes the required changes throughout the codebase. This means all files now use ESM by default, and files using CJS have to be explicitly marked as such.The commit Restore test environment reuse does just that, making
npm run testrun about 4 times as fast again.The other two commits just fix some inconsistencies: a few files used double quotes and not all internal node modules imports were marked as such.