Skip to content

Commit

Permalink
tools: Remove bashisms from the quick start devel scripts
Browse files Browse the repository at this point in the history
Michael Ellerman noticed we weren't using shebangs in those scripts. I
shrugged it off too quickly in the review, because it worked after all.
Turned out to be a bashmism, along with the usage of 'source'.

With those fixed, we have a better chance to run on most shells (famous
last words). Tested it with bash and dash.

Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
  • Loading branch information
Damien Lespiau committed Nov 10, 2015
1 parent 4da2a45 commit bb98c98
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions tools/run-devel.sh
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#!/bin/sh
# Patchwork - automated patch tracking system
# Copyright (C) 2015 Intel Corporation
#
Expand Down
3 changes: 2 additions & 1 deletion tools/setup-devel.sh
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#!/bin/sh
# Patchwork - automated patch tracking system
# Copyright (C) 2015 Intel Corporation
#
Expand Down Expand Up @@ -26,7 +27,7 @@ update_virtualenv()
requirements=$2

[ -d "$directory" ] || virtualenv "$directory"
source $directory/bin/activate
. $directory/bin/activate
pip install --upgrade -r $requirements
}

Expand Down

0 comments on commit bb98c98

Please sign in to comment.