Add support for multivalued attributes #59
Conversation
| Array(hash[node_name]).push(e.content) | ||
| else | ||
| e.content | ||
| end |
There was a problem hiding this comment.
This would be better stubbed out in a separate method
There was a problem hiding this comment.
@vjt Thanks for the feedback, see the updated changes. And glad to see this project is still active. 🎉
|
@tagliala could you help in updating Thank you |
|
This worked well in our environment (thanks @tagliala!) and it is backwards compatible, thus merging. Thanks! |
|
Thanks to you both! I noticed that there hasn't been a new release in a while (also brought up in #53). Is this waiting on an owner or a change in ownership? |
|
Derek @dlindahl has already granted gem ownership to me and other contributors, so we can definitely cut a new release once this is merged |
|
Please could you publish a new release quickly ? Thanks a lot for this update ! |
|
Sure, I’ll cut release 2.0.0 today. Thanks for thr heads up.
Marcello
--
// vjt@openssl.it
// https://sindro.me/
… On 14 Nov 2020, at 12:48, Julien Gribonvald ***@***.***> wrote:
Please could you publish a new release quickly ?
Thanks a lot for this update !
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
@jgribonvald 2.0.0 has been pushed to Ruby Gems. Enjoy and please revert back if something is wrong. Cheers! |
|
@vjt thanks a lot, I will let you know if something goes wrong. |
Currently we use CAS to return multi-valued attributes like entitlements/roles, which aren't natively supported by this omniauth provider and instead get set to the last value returned. Looking to add optional support for returning these multi-valued attributes as arrays while maintaining backwards compatibility by default.