-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation index #8
Conversation
И следующий шаг - по пунктам из |
docs/index.md
Outdated
- Split data into required parts (train, valid, test, ...). | ||
- Transform features to compatible format using pyspark or pandas functions. | ||
You can use also `ptls.data.preprocessing` for common data transformation patterns. | ||
- Split sequences to ptls-data format with `ptls.data.split_tools`. Save prepared data into parquet format or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parquet имеет смысл выдлелить, Pandas, Parquet, с большой буквы
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Может их ссылками сделать?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
можно, но думаю не обязательно
docs/index.md
Outdated
2. **Choose framework for encoder train**. | ||
- There are both supervised of unsupervised in `ptls.lightning_modules`. | ||
- Keep in mind that each framework requires his own batch format. | ||
Tools for batch collate are near selected framework. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be found in the selected framework package?
docs/index.md
Outdated
Tools for batch collate are near selected framework. | ||
3. **Build encoder**. | ||
- All parts are available in `ptls.trx_encoder`, `ptls.seq_encoder`, `ptls.heads`. | ||
- You can use early pretrained layers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also use pretrained layers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
В целом структура ок, есть небольшие комментарии по тексту, его можно будет постепенно улучшать
Прототип главной страницы документации.
Три секции:
Есть краткое описание и ссылки на подробные (которые напишем потом).
В описании модулей предложена структура библиотеки. Предполагается, что мы эти модули в ближайшее создадим и перетащим туда соответсвующие классы из библиотеки. Старые, модули, которые станут пустыми, удалим. Далее будем придерживаться схемы, описанной в этом документе.
На ревью предлагается чекнуть предлагаемую структуру библиотеки, названия модулей ну и сам описательный текст документа.