An empty Sass file should produce an empty CSS file #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if the input file is blank we bail out early, returning the input file object. This causes gulp to simply copy the input Sass file. We instead need to rewrite the file extension to .css. Fixes dlmanning#352
xzyfer
added a commit
to xzyfer/gulp-sass
that referenced
this pull request
Oct 5, 2015
We don't remove generated files between tests which results in false positives when asserting if a file was created. This was noticed when creating the test cases for dlmanning#358
xzyfer
added a commit
to xzyfer/gulp-sass
that referenced
this pull request
Oct 5, 2015
We don't remove generated files between tests which results in false positives when asserting if a file was created. This was noticed when creating the test cases for dlmanning#358
xzyfer
added a commit
to xzyfer/gulp-sass
that referenced
this pull request
Oct 5, 2015
We don't remove generated files between tests which results in false positives when asserting if a file was created. This was noticed when creating the test cases for dlmanning#358
xzyfer
added a commit
that referenced
this pull request
Oct 25, 2015
An empty Sass file should produce an empty CSS file
eoneill
pushed a commit
to eoneill/gulp-sass
that referenced
this pull request
Dec 3, 2015
We don't remove generated files between tests which results in false positives when asserting if a file was created. This was noticed when creating the test cases for dlmanning#358
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the input file is blank we bail out early, returning
the input file object. This causes gulp to simply copy the input
Sass file. We instead need to rewrite the file extension to .css.
Fixes #352