Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Sass 3.4.0 #374

Merged
merged 2 commits into from
Oct 25, 2015
Merged

Node Sass 3.4.0 #374

merged 2 commits into from
Oct 25, 2015

Conversation

xzyfer
Copy link
Collaborator

@xzyfer xzyfer commented Oct 25, 2015

This PR updates to the stable node-sass@^3.4.0.

It also updates the error messages to use LibSass pre-formatted errors. This means gulp-sass will now produce the exact same error messages as LibSass, node-sass, and grunt-sass.

Before

test/scss/error.scss
property "font" must be followed by a ':'

After

test/scss/error.scss
Error: property "font" must be followed by a ':'
        on line 2 of stdin
>>   font 'Comic Sans';
   --^

xzyfer added a commit that referenced this pull request Oct 25, 2015
@xzyfer xzyfer merged commit 830e7f8 into dlmanning:master Oct 25, 2015
@xzyfer xzyfer deleted the feat/node-sass-3-4 branch October 25, 2015 14:23
@mathiasbynens
Copy link

Could you npm publish a new version of gulp-sass containing these changes please?

I’m currently using git://github.com/dlmanning/gulp-sass.git#d7ca6a45e89ce878645c6c0582407452899bd7c7 as a dependency which feels kind of dirty.

@xzyfer
Copy link
Collaborator Author

xzyfer commented Oct 26, 2015

@mathiasbynens we're tracking the next release in #375

Unfortunately there are some issues with the latest LibSass we want to get sorted first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants