set modified time when modifying file #709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gulp plugins that create/modify output files are responsible for updating file modified timestamps as of Gulp 4 gulpjs/gulp#2193 (comment) This change simply updates the file stat appropriately. Fixes #706
|
Welp, it fails the tests, but the idea is right. |
|
Would be nice if this actually got merged ;) |
|
A colleague and I just spent 2.5 hours debugging an issue that was ultimately caused by gulp-sass not updating the mtime of the output files. It would be really nice if this was merged (after fixing the linting issue I guess). |
|
Either of you know how to fix this so the tests pass? |
|
Close in favor of #763 |
|
Released in v4.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gulp plugins that create/modify output files are responsible for updating file modified timestamps as of Gulp 4 gulpjs/gulp#2193 (comment)
This change simply updates the file stat appropriately.
Fixes #706