Make sourcemap source paths relative to file.base; fixes #92. #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,6 +4,7 @@ var gutil = require('gulp-util'); | |||
| var fs = require('fs'); | |||
| var path = require('path'); | |||
| var test = require('tape'); | |||
| var sourcemap = require('source-map'); | |||
There was a problem hiding this comment.
What's this supposed to be? It's making the automated tests fail.
|
Sorry about that require statement I forgot to remove. It didn't break my tests because it was installed locally I guess. |
|
Is there any word on this? |
|
Thanks! |
|
And thank you, @davidtheclark. @pspeter3, could you confirm this fixes the problem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From
gulp-sourcemaps:However, the generated source map from Libsass contains paths relative to the file itself, not
file.base. So to mediate between the two libraries I thinkgulp-sasshas to change the paths that come form Libsass, make them relative tofile.base, so they are correct forgulp-sourcemaps.All the existing tests still pass, and I added a new one for this particular situation.
This fix seems to take care of the problem I described in #92.