-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename blocking and defer to something easier to understand #10
Comments
I ❤️ the
Thoughts? |
The route transition will still be blocked, it's just that we will not wait util all the
The problem with this is that if we are in
Do you mean that we should always wait with firing any events util after |
I understand this, but I think the suggested rename makes this distinction less clear. If we
My idea is that if/when onError({
runTransitionHooksInParallel: true,
beforeTransitionSuccess: true,
afterTransitionSuccess: false,
failures: [{
component: function Dashboard() {},
beforeTransition: [],
afterTransition: ['trackStatistics', 'afterTransitionCompleted'],
}],
router,
location,
...
});
Yes, I'd like to, in some way, orchestrate the error notification in order to gather as much data as possible about the errors. And I don't think it's unreasonable to assume that in order for |
@PAkerstrand This makes sense, will do the needed adjustments for this in #7 |
I suggest we change some of the terminology used in the API to something easier to understand and reason about.
blocking
beforeTransition
defer
afterTransition
parallel
runAfterTransitionImmediately
Thoughts about this change?
The text was updated successfully, but these errors were encountered: