Adds support for async routes #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he matched "components" into account
3 tasks
dlmr
reviewed
Nov 2, 2016
| if (route.components) { | ||
| const foundNamedComponent = Object.keys(route.components) | ||
| components.some((matchedComponent, i) => { | ||
| if (typeof matchedComponent === 'object') { |
There was a problem hiding this comment.
We can probably use lodash.isplainobject here since we have it as a dependency already.
| result.name = key; | ||
| matchedComponent = matchedComponent[key]; // eslint-disable-line no-param-reassign |
There was a problem hiding this comment.
Are we sure that this mutation does not cause any problems? Seems like we are modifying renderProps indirectly here, no risk in doing so?
There was a problem hiding this comment.
Yeah, it doesn't (it just changes the bound matchedComponent-parameter).
But might be a bit too clever. I'll re-write it to make the intent easier to read
|
Looks good! We should probably add an example where we use async routes to verify that it also works in a "real" application. |
|
@dlmr Refactored |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for async routes by not only taking "routes", but also the matched "components" into account. This allows us to lazily load routes using webpacks code-splitting feature while preserving support for
get-andsetProps.