Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit skipped warning in JSON output #40

Closed
dloez opened this issue Oct 10, 2023 · 1 comment
Closed

Commit skipped warning in JSON output #40

dloez opened this issue Oct 10, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone
GitHub Actions

Comments

@dloez
Copy link
Owner

dloez commented Oct 10, 2023

If a commit does not match the used commit_pattern, a warning message indicating the commit SHA is displayed to warn the user which commits are being skipped to calculate the version bump. When the output format is set to JSON, this is still the behaviour.
If the output format is JSON, the application should add the skipped commits to the Output struct which will be then printed at the end of the execution.
@dloez dloez added enhancement New feature or request and removed needs triage labels Oct 10, 2023
@dloez dloez added this to the GitHub Actions milestone Oct 10, 2023
dloez added a commit that referenced this issue Oct 11, 2023
@dloez
feat: add skipped commits to JSON output as described in #40 and disp…
886806e 
…lay commits as warning in action
@dloez
Copy link
Owner Author

dloez commented Oct 11, 2023

An action output named skipped-commits has been also created for the github action.

@dloez dloez closed this as completed Oct 11, 2023
dloez added a commit that referenced this issue Oct 13, 2023
@dloez
feat: add skipped commits to JSON output as described in #40 and disp…
5d1df86 
…lay commits as warning in action
dloez added a commit that referenced this issue Oct 13, 2023
@dloez
feat: add skipped commits to JSON output as described in #40 and disp…
d237572 
…lay commits as warning in action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Tag Track
Archived in project
Milestone
GitHub Actions
Development

No branches or pull requests
1 participant
@dloez