Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Getting started instructions": no longer compatible with angular-13 + clarity-12 #101

Closed
MichaelLangbein opened this issue Nov 15, 2021 · 1 comment
Labels
bug fix: (Something isn't working)

Comments

@MichaelLangbein
Copy link
Collaborator

Describe the bug

The getting started section of our documentation describes how to set up a ukis project. Unfortunately, the current version of angular (13) and the current version of @clr/angular (12) are not compatible with each other

To Reproduce

ng new proj
cd proj
ng add @clr/angular

Yields error message:

‼ Unable to find compatible package.  Using 'latest' tag.
‼ Package has unmet peer dependencies. Adding the package may not succeed.

The package @clr/angular@12.0.7 will be installed and executed.
Would you like to proceed? Yes
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: clarityex@0.0.0
npm ERR! Found: @angular/common@13.0.1
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"~13.0.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^12.0.0" from @clr/angular@12.0.7
npm ERR! node_modules/@clr/angular
npm ERR!   @clr/angular@"12.0.7" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See C:\Users\lang_m13\AppData\Local\npm-cache\eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\lang_m13\AppData\Local\npm-cache\_logs\2021-11-15T10_49_26_348Z-debug.log
× Package install failed, see above.

Expected behavior

We should either document that we currently require angular 12, or update ukis to use the latest version of clarity (probably with webcomponents only).

Versions

App

  • Angular: @angular/common@13.0.1
  • Node: v.16.13.0
  • Clarity: @clr/angular@12.0.7
  • UKIS: not yet installed at this point of the reproduction

Additional context

Add any other context about the problem here.

@MichaelLangbein MichaelLangbein added the bug fix: (Something isn't working) label Nov 15, 2021
@boeckMt
Copy link
Member

boeckMt commented Dec 3, 2021

This is because you're trying to use Angular 13 with a Clarity Version for Angular 12.

If you create a new project with Angular 12 it should work.

Maybe we could update the Readme so that the user knows that he should use the same Angular Version like we do.

boeckMt added a commit that referenced this issue Dec 6, 2021
@boeckMt boeckMt closed this as completed in 0853809 Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix: (Something isn't working)
Projects
None yet
Development

No branches or pull requests

2 participants