Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vector tile layers, styling of layer control and simplify updates/usage #145

Merged
merged 35 commits into from
Oct 11, 2022
Merged

Update vector tile layers, styling of layer control and simplify updates/usage #145

merged 35 commits into from
Oct 11, 2022

Conversation

boeckMt
Copy link
Member

@boeckMt boeckMt commented Sep 23, 2022 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Starting with commit 31fd76e fix: set tile urls...

Does this PR introduce a breaking change?

  • Yes
  • No
  • remove class floating from clr-main-container
  • Package dependencies are set to allow Minor releases

Other information

Is it part of one/more packages and which?

  • @dlr-eoc/core-ui
  • @dlr-eoc/layer-control
  • @dlr-eoc/map-ol
  • @dlr-eoc/services-ogc
  • shared-assets
  • demo-maps
  • demo-auth

@boeckMt
fix: show button for settings if layer has action; closes #135
1d28eea
@boeckMt
fix: Show layer expand icon only when the layer has some things to ex…
29df062 
…pand
@boeckMt
refactor: move style switcher into settings tab
32107d1
@boeckMt
feat: Allow dynamic components for layer.description
8ef1c3b
@boeckMt
feat: Allow dynamic components for layer.description - set input
4fb1ab2
@boeckMt
feat: adjust types to allow Dynamic components for layer description
49f5a1d
@boeckMt
fix: Do not change the layer object binding in layerentry
c6c437e
@boeckMt
refactor: add example for layer.description as component
7d2e5c4
@boeckMt
feat: use inputs.description if possible to generate abstract from dy…
3a57c9d 
…namic component
@boeckMt
fix: Show layer expand icon if filtertype not Baselayers
0bc0ca9
@boeckMt
fix: remove right border on tabsbody for layers inside a group
26f7e3e
@boeckMt
fix: Do not change the group object binding in
6c2fd32
@boeckMt
fix: toggle group tabs and show all settings
78197b7
@boeckMt
feat: Allow Dynamic components for Group description
0256c2d
@boeckMt
feat: Allow legend on LayerGroup #138
39acc6b
@boeckMt
refactor: add example legend and description components for group
d7bf898
@boeckMt
fix: style for group tabsbody and actions button position
54127fa
@boeckMt
refactor: set input on layer IDynamicComponent - no object change nee…
82943dc 
…ded after c6c437e
@boeckMt
merge: main into layer-control-enhancements
c59066d
@boeckMt
fix: deprecated createComponent from componentFactory
2f82a6f
@boeckMt
fix: replace deprecated ComponentFactory
591eb78
@boeckMt
Merge branch 'main' into fix-dynamic-component
41e8e98
@boeckMt
fix: set tile urls in map style source which is used in ol-mapbox-style
31fd76e
@boeckMt
fix: prevent binding to the same element for duplicate IDs on multipl…
bb6e79f 
…e layer-controls
@boeckMt
refactor: update layer source in function
4b3780e
@boeckMt
refactor: remove unused imports
98974b1
@boeckMt
fix: test if layer has description on generate abstract
c782f0f
@boeckMt
fix: update vector tile style on layers and params or source on basel…
7291677 
…ayers
@boeckMt
refactor: add example to change vector tile style
0d2d292
@boeckMt
docs: add more instructions to work with the library and a project si…
63c0421 
…de by side
@boeckMt boeckMt added the BREAKING CHANGE BREAKING CHANGE: (A code change that introduces a breaking API change) label Sep 23, 2022
@boeckMt boeckMt changed the title Fix update v tile layer Fix update vector tile layer, styling of layer control and simplify updates/usage Sep 23, 2022
@boeckMt boeckMt changed the title Fix update vector tile layer, styling of layer control and simplify updates/usage Update vector tile layer, styling of layer control and simplify updates/usage Sep 23, 2022
@boeckMt boeckMt changed the title Update vector tile layer, styling of layer control and simplify updates/usage Update vector tile layers, styling of layer control and simplify updates/usage Sep 23, 2022
@boeckMt
Copy link
Member Author

boeckMt commented Sep 23, 2022

I would suggest building a new version after this pull request is merged.

lucas-angermann
lucas-angermann approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@lucas-angermann lucas-angermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for all the changes!

@boeckMt boeckMt merged commit 29c1cdd into main Oct 11, 2022
@boeckMt boeckMt deleted the fix-update-v-tile-layer branch October 11, 2022 07:09
boeckMt added a commit that referenced this pull request Oct 13, 2022
@boeckMt
tag: fix ci to prerelease #145
14cf39f
boeckMt added a commit that referenced this pull request Oct 13, 2022
@boeckMt
Update CI (#146)
b9d2936 
* ci: fix - replace old action and build only libraries

* tag: fix ci to prerelease #145

* ci: update vendor actions

* ci: update npm in ci for npm publish #129

* tag: update ci test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-angermann lucas-angermann lucas-angermann approved these changes

@MichaelLangbein MichaelLangbein Awaiting requested review from MichaelLangbein

@voinSR voinSR Awaiting requested review from voinSR

Assignees
No one assigned
Labels
BREAKING CHANGE BREAKING CHANGE: (A code change that introduces a breaking API change)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@boeckMt @lucas-angermann @MichaelLangbein