Fix build #90

boeckMt · 2021-06-24T11:24:58Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/dlr-eoc/ukis-frontend-libraries/blob/master/CONTRIBUTING.md#-commit-message-guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
The Project is building and passes all tests without errors

PR Type

What kind of change does this PR introduce?

What is the current behavior?

GitHub Actions is currently not publishing any packages to npm because they were built with ng build --prod=true which looks as it is not working correctly anymore since the change to "builder": "@angular-devkit/build-angular:ng-packagr".

See the workflow run https://github.com/dlr-eoc/ukis-frontend-libraries/runs/2903479305?check_suite_focus=true npm publish... for more details.

Found out that the original problem for the issue was NGCC running over the compiled packages #90 (comment) !

and Issue Number:

Correct options for depcheck #87

What is the new behavior?

NGCC was removed from the postinstall script. This corrected the build without compiling with NGCC so the script "scripts":{"prepublishOnly":"node --eval \"console.error('ERROR: Trying to publish a package that has been compiled by NGCC. This is not allowed.\\nPlease delete and rebuild the package, without compiling with NGCC, before attempting to publish.\\nNote that NGCC may have been run by importing this package into another project that is being built with Ivy enabled.\\n')\" && exit 1"}} is not added anymore to the packages.
Further Issue Correct options for depcheck #87 is fixed so depcheck should work correctly now.
The workspace files generated from angular where recreated, so we don't use any old configuration c0b5d81
Add Types for node again to the packages which need them for test and build 532b73b
Update angular to latest version before 12.x
Fixes Problem 2 Fix build #90 (comment)

Does this PR introduce a breaking change?

Yes
No

boeckMt · 2021-06-24T15:43:37Z

Problem 1
npm run build is using NGCC somehow:

Unfortunately the build still don't works like it is working on the local machine.
I tried to change the package look with npm v6.14.13 because of the following warning in the build npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2. I'll try to do my best with it! but this is also not working.
Maybe it is something with the npm cache in the GitHub runner workspace?

Problem 2
The problem why jobs not failing on publish:

run: find ./dist -mindepth 1 -maxdepth 1 -type d -exec bash -c "cd '{}' && npm run testexit" \ // exit codes of the subshells executed by find are not passed to the main shell.

boeckMt · 2021-07-08T12:42:39Z

Problem 1
npm run build is using NGCC somehow:

angular/angular#35762 -> This is happening on old library tsconfigs with

...
"angularCompilerOptions": {
   "enableIvy": false
 }
...

when running ngcc in our postinstall script, which unfortunately runs over the the downloaded artifact from the build job.

The compiler option

...
"angularCompilerOptions": {
   "compilationMode": "partial"
 }
...

which removes this behaviour is available in angular@12 so maybe remove ngcc from the postinstall till we can update to the new version.

This reverts commit 0dcae1e.

MichaelLangbein

Alright, that must have been a lot of work - thanks!
I did leave some comments, but they are only for clarification and fixing some typo's - so this PR is being approved immediately. @boeckMt : I'll leave merging to you, in case you want to add some docs about the comments in this review ... but honestly, I think that's optional, because build-processes change quickly anyway.

MichaelLangbein · 2021-07-14T06:22:08Z

projects/demo-maps/.browserslistrc

 # You can see what browsers were selected by your queries by running:
 #   npx browserslist

-> 0.5%
-last 2 versions
+last 1 Chrome version


Do we deliberately test only with latest Chrome, but with the two latest Safaris?

This was generated by angular, I only want to update the File because we did not change anything on it.

Roger that! No further questions.

MichaelLangbein · 2021-07-14T06:23:33Z

.github/workflows/package-main-release.yml

@@ -14,7 +14,7 @@ jobs:
      - uses: actions/checkout@v2
      - uses: actions/setup-node@v2
        with:
-          node-version: 14
+          node-version: 15


This comment is here only for documentation-purposes: a few days ago we have decided to build against the newest version of node, which might not always be the LTS. You're welcome, future generations!

To switch to this version was only a test, because the build stopped working somehow here eccac77 where only patch versions are changed. Thought it could be something with the cache of actions/setup-node@v2. At first I tried the newest node version 16 but it didn't work either. It looked like a problem with node-sass and node but it also doesn't worked after removal.

On the next week I used node 15 and it suddenly worked... I hope GitHub Actions will get better to debug in the future :)

Hm! Well, whatever works. Thanks for the heads up!

MichaelLangbein · 2021-07-14T06:26:12Z

projects/demo-maps/src/test.ts

@@ -1,13 +1,19 @@
 // This file is required by karma.conf.js and loads recursively all the .spec and framework files

+import 'zone.js/dist/zone';


There are several cases where we're importing zone alongside testing-zone for our unit-tests, but I don't see changes to the actual tests. Is this a CI requirement? Is it because we're no longer using karma-coverage-istanbul? Or because of those new async methods in the e2e tests?

Also generated by angular.

MichaelLangbein · 2021-07-14T06:31:32Z

scripts/library/README.md

+It uses the package scope `@dlr-eoc`, `main package.json` and the angular config file `angular.json`.
+
+
+- To get the list of all projects is reads the the angular config file (angular.json).


To get the list of all projects it reads the angular config file (angular.json).

done 9fb3013.

MichaelLangbein · 2021-07-14T06:32:08Z

scripts/library/README.md

+
+- To get the list of all projects is reads the the angular config file (angular.json).
+- To check all dependencies it uses the package scope `@dlr-eoc` and `depcheck`.
+- To get the build order it used `depcheck` and `toposort`.


To get the build order it uses depcheck and toposort.

done 57fd125.

boeckMt · 2021-07-14T07:16:20Z

Thanks for the review!

I have a few changes left, to adjust the workflow and ci scripts to fix Problem 2 -> #90 (comment).
You can check this later on.

…omment-867744242

boeckMt · 2021-07-14T12:39:19Z

A new error occurred on npm publish to npm registry in the action with npm version 7.7.6 from actions/setup-node@v2 node v15.14.0. Old version on the last working publish was npm 6.14.13 and node v14.17.0.

npm ERR! need auth You need to authorize this machine using `npm adduser`

boeckMt · 2021-07-15T12:22:05Z

Now it finally worked :)
https://github.com/dlr-eoc/ukis-frontend-libraries/actions/runs/1033733022 (Publish to GPR is failing here because it worked before)

boeckMt added 3 commits June 24, 2021 12:42

build: fix ng build --prod Deprecated - Ivy is enabled

8134572

build: fix depcheck options close #87

49f70ee

build: fix missing dependencies from depcheck

daf2771

boeckMt requested a review from MichaelLangbein June 24, 2021 11:25

Merge branch 'master' into fix-build

7d676f4

boeckMt marked this pull request as draft June 24, 2021 15:44

boeckMt removed the request for review from MichaelLangbein June 24, 2021 15:45

boeckMt marked this pull request as ready for review July 8, 2021 13:17

boeckMt added 16 commits July 8, 2021 16:38

build: remove ngcc which is compiling build libs #90

2889a33

docs: add documentation from ng

d9b3c6e

docs: add documentation from ng

695500c

build: recreate files generated from angular #90

c0b5d81

build: update dependencies for test changed #90

8a76f3f

build: add types for node #90

532b73b

build: update angular 11.2.14 #90

eccac77

build: recreate package lock and build prod before test #90

971df71

ci: set node version to 16 #90

0dcae1e

Revert "ci: set node version to 16 #90"

50f6765

This reverts commit 0dcae1e.

ci: remove not used node-sass

cc00be4

docs: add readme for scripts

415bf31

Merge branch 'fix-build-actions' into fix-build

f458d28

ci: set node to v15 for test and build

1cb9efb

ci: set node to v15 for workflows

19ad586

Merge branch 'fix-build-actions' into fix-build

a4d8836

MichaelLangbein approved these changes Jul 14, 2021

View reviewed changes

boeckMt added 3 commits July 14, 2021 09:01

docs: fix typo #90

9fb3013

Merge branch 'fix-build-actions' into fix-build

37d0be9

docs: fix typo #90

57fd125

boeckMt added 4 commits July 14, 2021 09:44

build: replace minimist with commander #90

8ea1a57

build: use commander for script arguments #90

4ba3a6b

build: include update package in index.ts #90

967bec9

ci: use node script and bash for loop to publish packages #90 -issuec…

8894b11

…omment-867744242

boeckMt added 3 commits July 14, 2021 15:09

ci: set node to v14 and npm v6 only for publish #90

9b61f82

ci: change node version for lockfile 2 and npm i v6.x for publish

675a5cb

ci: set auth token for npm publish and refactor workflow

adc6cdc

boeckMt merged commit 1c43e0b into master Jul 15, 2021

boeckMt deleted the fix-build branch July 15, 2021 12:23

boeckMt mentioned this pull request Dec 13, 2021

Fix version #107

Merged

14 tasks

boeckMt mentioned this pull request May 16, 2022

Update npm version in CI to publish packages in workflows #129

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix build #90

Fix build #90

boeckMt commented Jun 24, 2021 •

edited

boeckMt commented Jun 24, 2021 •

edited

boeckMt commented Jul 8, 2021 •

edited

MichaelLangbein left a comment

MichaelLangbein Jul 14, 2021

boeckMt Jul 14, 2021

MichaelLangbein Jul 14, 2021

MichaelLangbein Jul 14, 2021

boeckMt Jul 14, 2021 •

edited

MichaelLangbein Jul 14, 2021

MichaelLangbein Jul 14, 2021

boeckMt Jul 14, 2021

MichaelLangbein Jul 14, 2021

MichaelLangbein Jul 14, 2021

boeckMt Jul 14, 2021

MichaelLangbein Jul 14, 2021

boeckMt Jul 14, 2021

boeckMt commented Jul 14, 2021

boeckMt commented Jul 14, 2021 •

edited

boeckMt commented Jul 15, 2021

		@@ -1,13 +1,19 @@
		// This file is required by karma.conf.js and loads recursively all the .spec and framework files

		import 'zone.js/dist/zone';

		It uses the package scope `@dlr-eoc`, `main package.json` and the angular config file `angular.json`.


		- To get the list of all projects is reads the the angular config file (angular.json).

Fix build #90

Fix build #90

Conversation

boeckMt commented Jun 24, 2021 • edited

PR Checklist

PR Type

What is the current behavior?

Found out that the original problem for the issue was NGCC running over the compiled packages #90 (comment) !

What is the new behavior?

Does this PR introduce a breaking change?

boeckMt commented Jun 24, 2021 • edited

boeckMt commented Jul 8, 2021 • edited

MichaelLangbein left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

boeckMt Jul 14, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

boeckMt commented Jul 14, 2021

boeckMt commented Jul 14, 2021 • edited

boeckMt commented Jul 15, 2021

boeckMt commented Jun 24, 2021 •

edited

boeckMt commented Jun 24, 2021 •

edited

boeckMt commented Jul 8, 2021 •

edited

boeckMt Jul 14, 2021 •

edited

boeckMt commented Jul 14, 2021 •

edited