Owc fixes

[MichaelLangbein]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/dlr-eoc/ukis-frontend-libraries/blob/master/CONTRIBUTING.md#-commit-message-guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• The Project is building and passes all tests without errors

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

This PR fixes a few errors in the current implementation of OwcJsonService

• createVectorLayerFromOffering didn't work properly with WFS'es
• VectorLayers did not get the correct description based on an OWC's abstract field

What is the new behavior?

Errors have been fixed.

Does this PR introduce a breaking change?

• Yes
• No

Other information

Is it part of one/more packages and which?

• @dlr-eoc/services-ogc

[MichaelLangbein]

@boeckMt : should we create another next release with this PR? With that, we could remove the projects dir from CoastalX.

[boeckMt]

There are further Issues in creating layers from Offerings.
We often used offering.operations[0]

• https://github.com/dlr-eoc/ukis-frontend-libraries/blob/v7.3.2-next.3/projects/services-ogc/src/lib/owc/owc-json.service.ts#L701
• https://github.com/dlr-eoc/ukis-frontend-libraries/blob/v7.3.2-next.3/projects/services-ogc/src/lib/owc/owc-json.service.ts#L752
  we should filter for the correct operation.code like you did it here 46f88f6

Then offering.contents[0].content

• https://github.com/dlr-eoc/ukis-frontend-libraries/blame/v7.3.2-next.3/projects/services-ogc/src/lib/owc/owc-json.service.ts#L485
  we should check for the type and also what to do with multiple of the same types, or we only support one of each type.
  e.g. https://docs.opengeospatial.org/is/14-055r2/14-055r2.html#69
  e.g. type === 'application/gml+xml' or type === 'application/geo+json' (https://datatracker.ietf.org/doc/html/rfc7946#section-12)

For WFS we maybe also should check if the minimum required parameters are in the href

• https://docs.geoserver.org/latest/en/user/services/wfs/reference.html#getfeature
• https://docs.opengeospatial.org/is/09-025r2/09-025r2.html#176
• https://docs.opengeospatial.org/is/09-025r2/09-025r2.html#88

[boeckMt]

Update Types to fit the OWS Context GeoJSON Standard #97

e.g. values was changed to use period in display and not providing it like Geoserver

• values: '1984-01-01T00:00:00.000Z,1990-01-01T00:00:00.000Z,1995-01-01T00:00:00.000Z'
• values: '2000-09-01T00:00:00.000Z/2017-08-31T00:00:00.000Z/P1D'
  https://github.com/dlr-eoc/ukis-frontend-libraries/blob/v7.3.2-next.3/projects/services-ogc/src/lib/owc/types/eoc-owc-json.ts#L38

and now it can also be

{
  "name": "time",
  "values": "2003-01-01T00:00:00.000Z/2018-01-01T00:00:00.000Z",
  "units": "ISO8601",
  "display": {
     "default": "2003-01-01T00:00:00Z",
     "period": "P1Y"
   }
}

update https://github.com/dlr-eoc/ukis-frontend-libraries/blob/v7.3.2-next.3/projects/services-ogc/src/lib/owc/owc-json.service.ts#L222

[boeckMt]

Fix createLayerFromOffering https://github.com/dlr-eoc/ukis-frontend-libraries/blob/v7.3.2-next.3/projects/services-ogc/src/lib/owc/owc-json.service.ts#L454

createLayerFromOffering(offering: IOwsOffering, resource: IOwsResource, context: IOwsContext, targetProjection: string): Observable<Layer> {
    const layerType = this.getLayertypeFromOfferingCode(offering);
    if (isRasterLayertype(layerType)) {
      return this.createRasterLayerFromOffering(offering, resource, context, targetProjection);
    } else if (isVectorLayertype(layerType)) {
      return this.createVectorLayerFromOffering(offering, resource, context);
    } else if (layerType === TmsLayertype) {
      return this.createTmsLayerFromOffering(offering, resource, context, targetProjection);
    } else {
     //  console.error(`This type of service (${layerType}) has not been implemented yet.`);
      console.warn(`This type of service (${layerType}) has not been implemented yet.`);
      return of(<Layer>{});
    }
  }

Try to prevent using console.error and return an null/empty Observable here, otherwise the whole application stops working if someone uses a context with an unknown offering.code like "http://schemas.opengis.net/wms/1.1.1",

[MichaelLangbein]

Just to clarify:

• https://github.com/dlr-eoc/ukis-frontend-libraries/blob/v7.3.2-next.3/projects/services-ogc/src/lib/owc/types/eoc-owc-json.ts#L38

Here, do you mean that we should replace the type values: string; with a template-literal?

[boeckMt]

Just to clarify:

• https://github.com/dlr-eoc/ukis-frontend-libraries/blob/v7.3.2-next.3/projects/services-ogc/src/lib/owc/types/eoc-owc-json.ts#L38

Here, do you mean that we should replace the type values: string; with a template-literal?

No what I wanted to say is that we have to check if there is a period on the values
e.g.

• 1984-01-01T00:00:00.000Z/1989-12-31T23:59:59.000Z
  or it could be like
• 1984-01-01T00:00:00.000Z/1989-12-31T23:59:59.000Z/P1Y

We have such a function but it is not used in in the owc service https://github.com/dlr-eoc/ukis-frontend-libraries/blob/v7.3.2-next.3/projects/services-ogc/src/lib/owc/owc-json.service.ts#L199

---

But your proposal is a good Idea. We could type it e.g.

type isoInterval = `${string}/${string}`;
type intervalPeriod = `${isoInterval}/P${string}`;

export interface IEocOwsResourceDimension {
  name: 'time' | 'elevation';
  /**
   * For time:
   *  - '1984-01-01T00:00:00.000Z,1990-01-01T00:00:00.000Z,1995-01-01T00:00:00.000Z'
   *  - '2000-09-01T00:00:00.000Z/2017-08-31T00:00:00.000Z/P1D'
   */
  values: `${string},` | isoInterval | intervalPeriod;
 ...
}

It is not catching all cases but a bit more typesave.

https://www.typescriptlang.org/play?#code/C4TwDgpgBAlgzgewJIDtgQE4DcCGAbKAXigAMASAbzmAxhQHMBfAekutocZIG4AoUSLDSZceAAqYYCACZFSleMmHZ8LMWxp0mPfuGiiArhDhzyVTZwA0GjtqgAfWIlToVBR3VeiJtGX168AMYIKNRQALYgLiL4AFxOSl74RADk6NTM6cApQSFhkdFuPlLS8Z4x4pIyqVmZxsDMYlk5waHAEVHK3lXSAExlXfjF1YRp9Y3NuW0dAGr4RnAAjPGGxjX1LXntkXN4C-1QqyajWZab0zvzxgDMK1fHYxlNG1P5ILsLACx3e2vEjw1akCXkA

[boeckMt]

I think here it would be good if you also log the resource or offering so that the use knows what is causing this problem

[MichaelLangbein]

No what I wanted to say is that we have to check if there is a period on the values
e.g.

Not quite sure if I'm getting this right, but doesn't getTimeDimensions already check for the presence of a period in a IEocOwsResourceDimension?

I'm not certain if convertOwcTimeToIsoTimeAndPeriodicity is being used anywhere at all. It might be obsolete by now and replaced by getTimeDimensions. In that case it might make sense to remove this function, since we're moving to a new major version, anyway.

[boeckMt]

I'm not certain if convertOwcTimeToIsoTimeAndPeriodicity is being used anywhere at all. It might be obsolete by now and > replaced by getTimeDimensions. In that case it might make sense to remove this function, since we're moving to a new major > version, anyway.

Ah we used it in an earlier version of getTimeValueFromDimensions https://github.com/dlr-eoc/ukis-frontend-libraries/blob/v7.3.0/projects/services-ogc/src/lib/owc/owc-json.service.ts#L225 and it was not reused or removed.

But it looks like it is replaced by other functions, so you can remove it (but list it in the Breaking Changes please).

The only thing which is missing is, if period is null https://github.com/dlr-eoc/ukis-frontend-libraries/blob/v7.3.2-next.3/projects/services-ogc/src/lib/owc/owc-json.service.ts#L305 then it should not be added to dim.display.

---

And parsing of the operation.href was accidentally removed

https://github.com/dlr-eoc/ukis-frontend-libraries/blob/owcFixes/projects/services-ogc/src/lib/owc/owc-json.service.ts#L732

const getMapOperation = offering.operations.find(o => o.code === 'GetMap');

- const urlParams = getMapOperation.href;
+ const urlParams = this.getJsonFromUri(getMapOperation.href);

---

And can you pleas change https://github.com/dlr-eoc/ukis-frontend-libraries/blob/owcFixes/projects/services-ogc/src/lib/owc/owc-json.service.ts#L740

 const params: IWmsParams = {
        LAYERS: urlParams['LAYERS'],
        FORMAT: urlParams['FORMAT'],
        TIME: urlParams['TIME'],
        VERSION: urlParams['VERSION'],
        TILED: urlParams['TILED'],
        TRANSPARENT: true,
        STYLES: defaultStyle
      };

to

const params: IWmsParams = {
        LAYERS: urlParams['LAYERS'],
        TRANSPARENT: true,
        STYLES: defaultStyle
      };
      if (urlParams['FORMAT']) {
        params.FORMAT = urlParams['FORMAT'];
      }
      if (urlParams['TIME']) {
        params.TIME = params.urlParams['TIME'];
      }
      if (urlParams['VERSION']) {
        params.VERSION = urlParams['VERSION'];
      }
      if (urlParams['TILED']) {
        params.TILED = urlParams['TILED'];
      }

[MichaelLangbein]

All right, all comments are handled and all tests & build are working. Thanks a lot for the help, @boeckMt ! If nothing else is missing, I could now push new tags to the repo to trigger the pre-release. Is that alright with you?

[boeckMt]

Looks like everything is good now, great work.
Yes you can make the pre version.