Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the remaining FFI definitions into libc #20

Merged
merged 2 commits into from
Dec 3, 2022

Conversation

asomers
Copy link
Collaborator

@asomers asomers commented Nov 30, 2022

Fixes #18

Copy link
Owner

@dlrobertson dlrobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is really great and it's super awesome that you upstreamed the changes needed.

Cargo.toml Outdated
@@ -19,7 +19,7 @@ targets = [
]

[dependencies]
libc = "0.2.20"
libc = { git = "https://github.com/rust-lang/libc.git", rev = "d6fe782", features = [ "extra_traits" ] }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to wait for the libc version that contains this to be released instead of using the git commit.

Copy link
Owner

@dlrobertson dlrobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dlrobertson dlrobertson merged commit 4c855a0 into dlrobertson:master Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move all FFI definitions out of this crate
2 participants