Changes required for PB tools #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the AA storage, a PV name is broken up into parts and there are subdirectories with each part of the name. This method is to reverse that process so you can work out what a PV name is from the path to the PB file. The first three slashes in the path become dashes in the PV anme. Subsequent slashes become colons. E.g. "BL14I/MO/STAGE/01/XF.RBV:2019.pb" goes to "BL14I-MO-STAGE-01:XF.RBV"
Also more tests
|
(My plan would be to get these changes merged, and make a new release of aapy. Then I can depend on it in dls_pb_tools) |
Pull Request Test Coverage Report for Build 457
💛 - Coveralls |
Pull Request Test Coverage Report for Build 457
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 457
💛 - Coveralls |
Pull Request Test Coverage Report for Build 459
💛 - Coveralls |
willrogers
reviewed
Dec 5, 2019
|
Looks fine to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the work I have done in pb_tools I have moved to a new module dls_pb_tools
This takes with it the dependencies on PyQt5 and cothread, and means py < 3.6 can be reinstated.