Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for epicscorelibs and CI pypi publishing #11

Merged
merged 8 commits into from
Feb 22, 2021
Merged

Add support for epicscorelibs and CI pypi publishing #11

merged 8 commits into from
Feb 22, 2021

Conversation

thomascobb
Copy link
Contributor

@thomascobb thomascobb commented Feb 11, 2021 •
edited

Docs won't publish until we merge this to master, and a PyPI deployment won't go until we tag and push, but everything else should be done.

Fixes #6, supersedes #4

@thomascobb
Copy link
Contributor Author

ok, ready for review now...

Araneidae
Araneidae reviewed Feb 22, 2021
View reviewed changes
.gitattributes Outdated Show resolved Hide resolved
Pipfile Outdated Show resolved Hide resolved
epicsdbbuilder/dbd.py Outdated Show resolved Hide resolved
Araneidae
Araneidae reviewed Feb 22, 2021
View reviewed changes
Copy link
Member

@Araneidae Araneidae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes under discussion

Araneidae
Araneidae reviewed Feb 22, 2021
View reviewed changes
epicsdbbuilder/fanout.py Outdated Show resolved Hide resolved
Araneidae
Araneidae reviewed Feb 22, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@Araneidae Araneidae mentioned this pull request Feb 22, 2021
Closed
@Araneidae
Copy link
Member

Araneidae commented Feb 22, 2021 •
edited

Looks like there's a spurious .coverage database file introduced in commit b1a7ee2.

I see this gets removed in commit 9bf3d58, but it needs to be rebased out altogether.

@Araneidae
Copy link
Member

Can you please rebase out .coverage from commit b1a7ee2, then we're good to go.

@thomascobb
Copy link
Contributor Author

Can you please rebase out .coverage from commit b1a7ee2, then we're good to go.

done

@Araneidae
Copy link
Member

Araneidae commented Feb 22, 2021 •
edited

Looks good, think I'm happy

@Araneidae Araneidae merged commit ca3db92 into master Feb 22, 2021
@thomascobb thomascobb deleted the pypi branch February 22, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Araneidae Araneidae Araneidae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

License information is missing
3 participants
@thomascobb @Araneidae @coretl