Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the logic releted to ppmac InPos and group comments for turbo and ppmac #13

Merged
merged 2 commits into from
May 23, 2024

Conversation

UrszulaNeuman
Copy link
Collaborator

@UrszulaNeuman UrszulaNeuman commented May 23, 2024

This pull request addresses the following problems:

  1. On power pmac the group command was broken - it only worked when there was one motor in a group. This is now fixed so that both of the controllers use the same mechanism and the comments look correctly even when more motors are added to a group.
  2. When the group didn't have any comment 'None' word was added to the comment without the comment operator (; for turbo or // for ppmac).
  3. InPos condition on ppmac was wrong it used && instead of || to combine InPos status for motors in one group.

@UrszulaNeuman UrszulaNeuman merged commit 9042c58 into master May 23, 2024
12 checks passed
@UrszulaNeuman UrszulaNeuman deleted the plimits branch May 23, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant