Style changes for linting

malcolm/core/block.py

@@ -7,6 +7,7 @@
 from malcolm.core.attribute import Attribute
 from malcolm.core.method import Method
 
+
 class DummyLock(object):
 
     def acquire(self):
@@ -18,21 +19,23 @@ def release(self):
     def __enter__(self):
         self.acquire()
 
-    def __exit__(self, type, value, traceback):
+    def __exit__(self, type_, value, traceback):
         self.release()
         return False
 
+
 class LockRelease(object):
     def __init__(self, lock):
         self.lock = lock
 
     def __enter__(self):
         self.lock.release()
 
-    def __exit__(self, type, value, traceback):
+    def __exit__(self, type_, value, traceback):
         self.lock.acquire()
         return False
 
+
 @Serializable.register_subclass("malcolm:core/Block:1.0")
 class Block(Notifier):
     """Object consisting of a number of Attributes and Methods"""

malcolm/core/controller.py

@@ -89,11 +89,11 @@ def transition(self, state, message):
 
             self.status.set_value(message)
 
-            for method in self.block._methods.values():
+            for method in self.block.methods.values():
                 if method in self.writeable_methods[state]:
-                    self.block._methods[method].set_writeable(True)
+                    self.block.methods[method].set_writeable(True)
                 else:
-                    self.block._methods[method].set_writeable(False)
+                    self.block.methods[method].set_writeable(False)
 
             self.block.notify_subscribers()
 

malcolm/core/spawnable.py

@@ -22,14 +22,14 @@ def start(self, process=None):
         if process is None:
             process = self.process
         self._initialize()
-        for (func, stop_func) in self._spawn_functions:
+        for (func, _) in self._spawn_functions:
             self._spawned.append(process.spawn(func))
 
     def stop(self):
         """Call registered stop functions"""
 
         self._initialize()
-        for (func, stop_func) in reversed(self._spawn_functions):
+        for (_, stop_func) in reversed(self._spawn_functions):
             if stop_func is not None:
                 stop_func()
 

malcolm/wscomms/wsclientcomms.py

@@ -58,7 +58,7 @@ def stop_recv_loop(self):
         # thread
         self.loop.add_callback(self.loop.stop)
 
-    def subscribe_server_blocks(self, conn):
+    def subscribe_server_blocks(self, _):
         """Subscribe to process blocks"""
         request = Request.Subscribe(None, None, [".", "blocks", "value"])
         request.set_id(self.SERVER_BLOCKS_ID)

malcolm/wscomms/wsservercomms.py

@@ -1,8 +1,3 @@
-import os
-import sys
-sys.path.append(os.path.join(os.path.dirname(__file__), ".."))
-import setup_malcolm_paths
-
 from collections import OrderedDict
 import json
 

tests/test_core/test_controller.py

@@ -26,10 +26,10 @@ class TestController(unittest.TestCase):
 
     def setUp(self):
         b = MagicMock()
-        b._methods.values.return_value = ["say_hello", "say_goodbye"]
+        b.methods.values.return_value = ["say_hello", "say_goodbye"]
         self.m1 = MagicMock()
         self.m2 = MagicMock()
-        b._methods.__getitem__.side_effect = [self.m1, self.m2]
+        b.methods.__getitem__.side_effect = [self.m1, self.m2]
         self.c = DummyController(MagicMock(), b)
 
     def test_init(self):