Merge pull request #15 from dls-controls/getattr-magic

Added getattr magic to Response
dls-controls · Jun 3, 2016 · 91d591f · 91d591f
2 parents 488a1c6 + 3fd61cd
commit 91d591f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/malcolm/core/response.py b/malcolm/core/response.py
@@ -18,6 +18,9 @@ def to_dict(self):
             serialized[field] = value
         return serialized
 
+    def __getattr__(self, attr):
+        return self.fields[attr]
+
     @classmethod
     def Return(cls, id_, context, value=None):
         """Create a Return response object with the provided parameters.

diff --git a/tests/test_core/test_response.py b/tests/test_core/test_response.py
@@ -46,5 +46,10 @@ def test_return_response_to_dict(self):
         expected["value"] = None
         self.assertEquals(expected, r.to_dict())
 
+    def test_getattr(self):
+        r = Response.Return(22, None, "bar")
+        self.assertEquals(r.value, "bar")
+        self.assertRaises(KeyError, lambda: r.ffff)
+
 if __name__ == "__main__":
     unittest.main(verbosity=2)