Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotypes #226

Merged
merged 84 commits into from Jul 16, 2018
Merged

Annotypes #226

merged 84 commits into from Jul 16, 2018

Conversation

thomascobb
Copy link

No description provided.

coretl and others added 10 commits June 12, 2018 14:36
Conflicts:
	malcolm/core/block.py
	malcolm/core/context.py
	malcolm/modules/ADCore/parts/hdfwriterpart.py
	malcolm/modules/excalibur/parts/vdswrapperpart.py
	malcolm/modules/pmac/includes/brick_collection.yaml
	malcolm/modules/pmac/parts/pmactrajectorypart.py
	tests/test_core/test_block.py
	tests/test_core/test_context.py
This also means that the Attribute meta writeable trumps the child
elements writeable fields
The method writeable attribute should now be used to check if a method
takes parameter is writeable
@codecov-io
Copy link

codecov-io commented Jun 15, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@bf48ad3). Click here to learn what that means.
The diff coverage is 92.89%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #226   +/-   ##
=========================================
  Coverage          ?   88.08%           
=========================================
  Files             ?      176           
  Lines             ?     7797           
  Branches          ?        0           
=========================================
  Hits              ?     6868           
  Misses            ?      929           
  Partials          ?        0
Impacted Files Coverage Δ
malcolm/modules/profiling/parts/__init__.py 0% <ø> (ø)
malcolm/modules/pva/controllers/pvautil.py 78.57% <ø> (ø)
malcolm/modules/scanning/util.py 98.24% <ø> (ø)
malcolm/core/errors.py 100% <ø> (ø)
malcolm/modules/scanning/controllers/__init__.py 100% <ø> (ø)
malcolm/modules/pmac/parts/rawmotorcspart.py 96.87% <ø> (ø)
malcolm/modules/web/__init__.py 100% <ø> (ø)
malcolm/modules/web/controllers/httpservercomms.py 95.91% <ø> (ø)
malcolm/modules/pva/controllers/pvaservercomms.py 16.4% <ø> (ø)
malcolm/modules/web/parts/websocketserverpart.py 80% <ø> (ø)
... and 138 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf48ad3...e8fd3d7. Read the comment docs.

@thomascobb thomascobb merged commit e8fd3d7 into master Jul 16, 2018
@thomascobb thomascobb deleted the annotypes branch July 16, 2018 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants