Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have RegexCommand.parse return more information #93

Closed
MattPrit opened this issue Sep 5, 2022 · 0 comments
Closed

Have RegexCommand.parse return more information #93

MattPrit opened this issue Sep 5, 2022 · 0 comments

Comments

@MattPrit
Copy link
Collaborator

MattPrit commented Sep 5, 2022

Required for #90
The more complex MultiCommandInterpreter requires more information to be returned form parse. Specifically, it requires information about where within the message a match is found; these indices need to be with respect to the original message, not (if applicable) the message after it has been decoded. This could be achieved by encoding the regex pattern rather than decoding the message when format is not None.
Since there will be changes to the return signature of Command.parse, the handle method of CommandInterpreter will need to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants