Add DecodingInterpreter and EncodingInterpreter #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 98.56% 98.58% +0.01%
==========================================
Files 67 68 +1
Lines 2097 2120 +23
==========================================
+ Hits 2067 2090 +23
Misses 30 30
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Closed
garryod
requested changes
Sep 7, 2022
Comment on lines
+26
to
+28
| async def handle( | ||
| self, adapter: Adapter, message: AnyStr | ||
| ) -> Tuple[AsyncIterable[AnyStr], bool]: |
There was a problem hiding this comment.
This should be typed as:
Suggested change
| async def handle( | |
| self, adapter: Adapter, message: AnyStr | |
| ) -> Tuple[AsyncIterable[AnyStr], bool]: | |
| async def handle( | |
| self, adapter: Adapter, message: bytes | |
| ) -> Tuple[AsyncIterable[str], bool]: |
Though it may require us to use a contravarient version of AnyStr in the Interpreter definition
Comment on lines
+67
to
+69
| async def handle( | ||
| self, adapter: Adapter, message: AnyStr | ||
| ) -> Tuple[AsyncIterable[AnyStr], bool]: |
There was a problem hiding this comment.
This should be typed as:
Suggested change
| async def handle( | |
| self, adapter: Adapter, message: AnyStr | |
| ) -> Tuple[AsyncIterable[AnyStr], bool]: | |
| async def handle( | |
| self, adapter: Adapter, message: str | |
| ) -> Tuple[AsyncIterable[bytes], bool]: |
Though it may require us to use a contravarient version of AnyStr in the Interpreter definition
|
Closing this as not planned. When it becomes desired again raise a new issue, linked to this #177. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds interpreter wrappers that decode/encode messages before passing them on to the wrapped interpreter. This should facilitate the removal of encoding/decoding logic from within
RegexCommand.