StageManager support for fullscreen, always on top and maximized

[trixon]

A while back I wrote a similar thing like your stage manager
https://github.com/trixon/almond/blob/3880029726706ab0122de308af2a636860b602a4/util/src/main/java/se/trixon/almond/util/fx/FxHelper.java#L533
but without your screen management and by occupying stage.setOnCloseRequest.

What it does have is support for fullscreen, always on top and maximized.

Do you have any plans for that or should I use part of your code in mine?

[dlemmermann]

Maybe contribute to GemsFX via pull request? Patrik Karlström ***@***.***> schrieb am Sa. 9. Apr. 2022 um 20:19:

A while back I wrote a similar thing like your stage manager https://github.com/trixon/almond/blob/3880029726706ab0122de308af2a636860b602a4/util/src/main/java/se/trixon/almond/util/fx/FxHelper.java#L533 but without your screen management and by occupying stage.setOnCloseRequest. What it does have is support for fullscreen, always on top and maximized. Do you have any plans for that or should I use part of your code in mine? — Reply to this email directly, view it on GitHub <#50>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACIXWXKOPWAH6AJKKV35RIDVEHC3NANCNFSM5S7UAC4Q> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- Dirk Lemmermann Software & Consulting Zurich, Switzerland +41-(0)79-800-23-20 http://www.dlsc.com ***@***.***

[dlemmermann]

Wanna contribute that?

[trixon]

Sure thing, now that I manage to submit a PR, I'm not really comfortable with that, yet.

[trixon]

I'm holding always on top for now, not sure if it's a good idea to have it there, unless one could opt-out from it and the other settings too with some configurator object.

Submitted a PR for the others but it the check failed, is it something I'm supposed to do/fix? @dlemmermann

[dlemmermann]

The check failed because part of the build is a QA analysis via Sonarcube and I am the only one allowed to call it :-( Something to look into by me.