Fields migrate state private2protected #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dlemmermann What do you think about this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
PreferencesFX project has sources from FormsFX project for various controls. These fields have been made public in latest versions of same sources under FormsFX (https://github.com/dlsc-software-consulting-gmbh/FormsFX/pull/28/files#diff-417ae9bbd300ffa2be7fb7c286928a1dd4629cce71d656205fc12739e33796b9). Due to these fields still having Private modifiers within sources in PreferencesFX, its not possible to access those from derived classes in order to add listeners.
What is the new behavior?
I have modified the private fields to protected to access those by derived classes. This is in line with the latest changes in the same source files in latest revisions of FormsFX (https://github.com/dlsc-software-consulting-gmbh/FormsFX/pull/28/files#diff-417ae9bbd300ffa2be7fb7c286928a1dd4629cce71d656205fc12739e33796b9). This allows users to access them from derived
classes in order to add listeners.