Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IkonliBrowser: How should downloads be handled? #26

Open
aalmiray opened this issue Jul 25, 2021 · 6 comments
Open

IkonliBrowser: How should downloads be handled? #26

aalmiray opened this issue Jul 25, 2021 · 6 comments

Comments

@aalmiray
Copy link

Ikonli's release has been updated, ikonli-browser now posts ZIPs and native packagers

https://github.com/kordamp/ikonli/releases/tag/12.3.0.EarlyAccess

How many entries and which ones should be listed as download buttons?

@dlemmermann
Copy link
Collaborator

dlemmermann commented Jul 25, 2021 via email

@FlorianKirmaier
Copy link
Collaborator

I've removed the download to the ikonly browser for now.

This was the content in the downloads:

  {
    "id": "ikonlibrowser",
    "name": "Ikonli Browser",
    "tags": "icons, library, demo, application",
    "downloadType": "APPLICATION",
    "personIds": [
      "a.almiray"
    ],
    "createdOn": "2021-06-02",
    "modifiedOn": "2021-06-02",
    "files": [
      {
        "name": "ZIP for Linux",
        "url": "https://github.com/kordamp/ikonli/releases/download/early-access/ikonli-browser-early-access-linux.zip",
        "fileName": "",
        "package": "ZIP"
      },
      {
        "name": "ZIP for Mac",
        "url": "https://github.com/kordamp/ikonli/releases/download/early-access/ikonli-browser-early-access-mac.zip",
        "fileName": "",
        "package": "ZIP"
      },
      {
        "name": "ZIP for Windows",
        "url": "https://github.com/kordamp/ikonli/releases/download/early-access/ikonli-browser-early-access-windows.zip",
        "fileName": "",
        "package": "ZIP"
      }
    ],
    "tipIds": [
      "ikonli"
    ]
  },

@aalmiray
Copy link
Author

@FlorianKirmaier Why remove? Why not update to the latest file names such as ikonli-browser-12.3.0.EarlyAccess-osx-x86_64.zip?

@FlorianKirmaier
Copy link
Collaborator

I didn't found the new downloadlinks initially.
Guess I was waiting for someone to tell me the new link, thank you!
I've updated it yesterday.
But we probably need a more maintainable solution - so I keep it open for now.

@aalmiray
Copy link
Author

Thanks! I opened this issue as ikonli-browser provides lost of options (currently 8!) and I suppose there may be some preferred over others.

@dlemmermann
Copy link
Collaborator

We could also just point to the "releases" page on the GitHub repo instead of a direct download link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants