Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes naive datetime bug in incremental #1020

Merged
merged 7 commits into from Mar 1, 2024
Merged

fixes naive datetime bug in incremental #1020

merged 7 commits into from Mar 1, 2024

Conversation

rudolfix
Copy link
Collaborator

Description

  1. fixes various edge cases when naive row values at cursor were not converted into pendulum UTC (json incremental)
  2. arrow incremental always handles naive date times as UTC

@rudolfix rudolfix requested a review from sh-rp February 27, 2024 18:15
@netlify Netlify
Copy link

netlify bot commented Feb 27, 2024 •
edited

✅ Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit af4f60a
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/65e1059f5e14420008caa42a

@rudolfix rudolfix force-pushed the rfix/fixes-naive-datetime-bug branch from fe1a65f to af4f60a Compare February 29, 2024 22:30
@rudolfix rudolfix merged commit 7e1163b into devel Mar 1, 2024
57 of 66 checks passed
@rudolfix rudolfix deleted the rfix/fixes-naive-datetime-bug branch March 1, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh-rp sh-rp Awaiting requested review from sh-rp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rudolfix