Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): validation error with TTableHintTemplate #1039

Merged
merged 5 commits into from Mar 4, 2024
Merged

fix(core): validation error with TTableHintTemplate #1039

merged 5 commits into from Mar 4, 2024

Conversation

IlyaFaer
Copy link
Collaborator

@IlyaFaer IlyaFaer commented Mar 1, 2024 •
edited

Fixes #999

I don't have this error on Python 3.10 and Python 3.11. Both versions had some changes in typing and its generics, so it seems to be an error of older Python versions.

@netlify Netlify
Copy link

netlify bot commented Mar 1, 2024 •
edited

✅ Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit e890fcb
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/65e58a80f9690f00085c8a30

burnash
burnash requested changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @IlyaFaer could you please also extend the test?

tests/common/test_validation.py Show resolved Hide resolved
@IlyaFaer IlyaFaer marked this pull request as ready for review March 4, 2024 09:37
burnash
burnash approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @IlyaFaer

rudolfix
rudolfix approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well!

@rudolfix rudolfix merged commit 483d4ae into devel Mar 4, 2024
56 of 66 checks passed
@rudolfix rudolfix deleted the validate_no_name branch March 4, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burnash burnash burnash approved these changes

@rudolfix rudolfix rudolfix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.8-9: AttributeError in validate_dict() with TTableHintTemplate
3 participants
@IlyaFaer @burnash @rudolfix