simplifies and fixes incremental / fixes #971 #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng criteria when to deduplicate, unique index in arrow frames rarely created
rudolfix
added
bug
✅ Deploy Preview for dlt-hub-docs canceled.
|
rudolfix
force-pushed
the
rfix/simplifies-and-fixes-incremental
branch
from
e18b971
to
abc46b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had reports coming that incremental load generates duplicate rows (ie. #971). There were indeed such cases.
This PR simplifies incremental code, optimizes generation of hashes (incremental on json should work way quicker now) and fixes (hopefully) edge cases on unordered ranges