Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Deploy dlt on dagster #1086

Merged
merged 18 commits into from Apr 2, 2024
Merged

Docs: Deploy dlt on dagster #1086

merged 18 commits into from Apr 2, 2024

Conversation

dat-a-man
Copy link
Collaborator

Description

Adding documentation on deploying dlt on Dagster

Related Issues

  • Fixes #...
  • Closes #...
  • Resolves #...

Additional Context

Copy link

netlify bot commented Mar 13, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 17c15aa
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/660bda4a43742100080510ce
😎 Deploy Preview https://deploy-preview-1086--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dat-a-man dat-a-man requested a review from zem360 March 13, 2024 05:04
@dat-a-man dat-a-man added the documentation Improvements or additions to documentation label Mar 18, 2024
Copy link
Contributor

@zem360 zem360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the writeup is good. Without some code it seems like I get nothing out of the page, so added some snippets.

@dat-a-man dat-a-man self-assigned this Mar 26, 2024
Copy link
Contributor

@zem360 zem360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

zem360
zem360 previously approved these changes Mar 27, 2024
Copy link
Contributor

@zem360 zem360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging

Adding import DltResource in the Definition script.
Removing DltResource args
Changing resource name from DltResource to DltPipeline
Copy link
Contributor

@zem360 zem360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting Passed.

@zem360 zem360 merged commit ea22515 into devel Apr 2, 2024
44 checks passed
@zem360 zem360 deleted the docs/deploy-dlt-on-dagster branch April 2, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants