Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for default schema and schema name in streamlit session #1155

Merged
merged 5 commits into from
Apr 22, 2024

Conversation

sultaniman
Copy link
Collaborator

This PR adds additional checks in case if pipeline ran but no data was loaded so we can show better error messages instead of showing a stack trace.

@sultaniman sultaniman added bug Something isn't working enhancement New feature or request labels Mar 27, 2024
@sultaniman sultaniman self-assigned this Mar 27, 2024
Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit 65a6d57
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/661fd8f4e49ce40009fa8f94

rudolfix
rudolfix previously approved these changes Apr 1, 2024
@sultaniman sultaniman force-pushed the fix/streamlit-better-default-schema-checks branch from e7d586e to d925c69 Compare April 2, 2024 07:30
@rudolfix
Copy link
Collaborator

rudolfix commented Apr 3, 2024

@sultaniman is this fixing also this problem?
image

@sultaniman
Copy link
Collaborator Author

Updated the streamlit app so it doesn't show annoying error message if there is no resource state in pipeline

@sultaniman sultaniman force-pushed the fix/streamlit-better-default-schema-checks branch from 40959e8 to 6339165 Compare April 17, 2024 13:34
@sultaniman sultaniman force-pushed the fix/streamlit-better-default-schema-checks branch from 6339165 to 65a6d57 Compare April 17, 2024 14:13
@rudolfix
Copy link
Collaborator

@sultaniman pls post a pic with the current UI :)

@sultaniman
Copy link
Collaborator Author

sultaniman commented Apr 17, 2024

Yessir!
image

@rudolfix rudolfix merged commit f6295f9 into devel Apr 22, 2024
45 of 48 checks passed
@rudolfix rudolfix deleted the fix/streamlit-better-default-schema-checks branch April 22, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants