Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yaml representer for pendulum datetime #1192

Merged
merged 2 commits into from Apr 5, 2024

Conversation

sultaniman
Copy link
Collaborator

This PR fixes the bug reported in #1189 where yaml.safe_dump is unable to serialize pendulum.[Date|DateTime] it aliases with yaml's builtin Dumper.represent_datetime which uses ISO format.

@sultaniman sultaniman added the bug Something isn't working label Apr 5, 2024
@sultaniman sultaniman requested a review from rudolfix April 5, 2024 13:06
@sultaniman sultaniman self-assigned this Apr 5, 2024
Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit 54437eb
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/660ffa6eab5d270008977cf5

Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rudolfix rudolfix merged commit bded03c into devel Apr 5, 2024
47 of 53 checks passed
@rudolfix rudolfix deleted the fix/streamlit-handle-datetimes-in-yaml branch April 5, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants