Revert tzdata update and update lock #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
rudolfix
requested changes
Apr 17, 2024
There was a problem hiding this comment.
@sultaniman please add
- new label "changes dependencies" that we will add to PRs that change deps
- explanation to CONTRIBUTING:
### Add / update / remove core library dependencies
where you'll explain the process and why we do it!
sultaniman
force-pushed
the
deps/revert-tzdata-update
branch
from
d3c5ee7
to
43e738e
Compare
sh-rp
reviewed
Apr 18, 2024
CONTRIBUTING.md
Outdated
| The other important note on using possible version minimas is to prevent potential cases where package | ||
| versions will not be resolvable. | ||
|
|
||
| ### Hypothetical example: |
There was a problem hiding this comment.
I think we can scrap this section, the above section is clear enough. Also we are not as much concerned about breaking changes (I think) than about other libs our users are using which will collide with our requirements, so in this case we would not enforce a higher minimal version I think. @rudolfix wdyt.
rudolfix
requested changes
Apr 18, 2024
There was a problem hiding this comment.
yeah now it makes sense! @sultaniman @sh-rp should we introduce a label to warns that dependencies are updated? or maybe we add this to the PR template? so you must say if you update core deps or not
@sultaniman you can drop the example
rudolfix
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts tzdata update in pyproject.toml and updates lockfile.