Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filesystem layout timestamps with milliseconds #1286

Merged
merged 8 commits into from
Apr 26, 2024

Conversation

sultaniman
Copy link
Collaborator

This PR uses datetime.timestamp() for timestamps with milliseconds instead of pendulum.format().
I thought it was fixed but apparently got mixed up.

@sultaniman sultaniman added the bug Something isn't working label Apr 25, 2024
@sultaniman sultaniman self-assigned this Apr 25, 2024
Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit ce5e6f9
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/662b967c1364d100083aab21
😎 Deploy Preview https://deploy-preview-1286--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please tell me what was the bug really? "SSS" is a milisecond part of a datetime, not a full timestamp? hard to review without knowing what got fixed
otherwise LGTM

@sultaniman
Copy link
Collaborator Author

sultaniman commented Apr 25, 2024

@rudolfix yes it SSS is just a millisecond part of it and pendulum has x but it is a stringified timestamp with seconds and now it is just the old way of doing timestamp*1000. Switching between the tasks I overlooked this. Sorry.

tests/common/test_time.py Outdated Show resolved Hide resolved
@sultaniman sultaniman requested a review from sh-rp April 25, 2024 16:27
@sultaniman sultaniman force-pushed the fix/file-system-layout-timestamps-with-milliseconds branch from bd9bb15 to d1a4df9 Compare April 25, 2024 17:49
@sh-rp
Copy link
Collaborator

sh-rp commented Apr 26, 2024

looks good, maybe one additional request: put an example in the docs. Right now it says "timestamp_ms - the current timestamp in Unix Timestamp format rounded to milliseconds" which is not quite right, because it is not a unix timestamp rounded to ms (this would look like this: 12334455.233) but it looks like this: 12334455233 actually.

PS: Maybe it is considered a unix timestamp, that's my bad, but an example would be good.

@sultaniman sultaniman force-pushed the fix/file-system-layout-timestamps-with-milliseconds branch from be2f7ff to ce5e6f9 Compare April 26, 2024 11:56
@sultaniman sultaniman merged commit f7ef3e4 into devel Apr 26, 2024
48 checks passed
@sultaniman sultaniman deleted the fix/file-system-layout-timestamps-with-milliseconds branch April 26, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants