-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix filesystem layout timestamps with milliseconds #1286
Fix filesystem layout timestamps with milliseconds #1286
Conversation
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please tell me what was the bug really? "SSS" is a milisecond part of a datetime, not a full timestamp? hard to review without knowing what got fixed
otherwise LGTM
@rudolfix yes it |
bd9bb15
to
d1a4df9
Compare
looks good, maybe one additional request: put an example in the docs. Right now it says "timestamp_ms - the current timestamp in Unix Timestamp format rounded to milliseconds" which is not quite right, because it is not a unix timestamp rounded to ms (this would look like this: 12334455.233) but it looks like this: 12334455233 actually. PS: Maybe it is considered a unix timestamp, that's my bad, but an example would be good. |
…mall millisecond drifts in timestamps
be2f7ff
to
ce5e6f9
Compare
This PR uses
datetime.timestamp()
for timestamps with milliseconds instead of pendulum.format().I thought it was fixed but apparently got mixed up.