Do not show a notice if there is no resource state for schema #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
|
@sultaniman Is there some way of writing some tests for this? |
|
@sh-rp unfortunately current testing support is not very pytest friendly streamlit/streamlit#5683 and I would say is incomplete for example if you would like to go beyond simply testing clicks and rendering it will be impossible to do because |
rudolfix
approved these changes
Apr 30, 2024
| @@ -24,9 +24,9 @@ def resource_state_info( | |||
| sources_state = pipeline.state.get("sources") or {} | |||
There was a problem hiding this comment.
we need to start using helper methods to get source and resource state but OK for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the UI in streamlit app to not show notice message if there is no resource state for the given schema.
Related to: #1264