Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESTClient: implement AuthConfigBase.__bool__ + update docs #1398

Merged
merged 3 commits into from
May 24, 2024

Conversation

burnash
Copy link
Collaborator

@burnash burnash commented May 22, 2024

This PR implements __bool__ on AuthConfigBase so instances of this class evaluate to True in requests.sessions.Session.prepare_request() when auth argument is evaluated otherwise instances of AuthConfigBase have no effect when passed as arguments to RESTClient's methods.

The PR also updates the documentation to suggest explicit inheritance from requests.auth.AuthBase for custom authentication.

@burnash burnash requested a review from rudolfix May 22, 2024 16:46
Copy link

netlify bot commented May 22, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit b4e417e
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/664e213ca2889100088c845b
😎 Deploy Preview https://deploy-preview-1398--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@burnash burnash self-assigned this May 22, 2024
@burnash burnash added bug Something isn't working documentation Improvements or additions to documentation labels May 22, 2024
@burnash burnash requested a review from sultaniman May 22, 2024 16:46
Copy link
Collaborator

@sultaniman sultaniman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so good!

@rudolfix rudolfix merged commit ceb229d into devel May 24, 2024
42 of 50 checks passed
@rudolfix rudolfix deleted the fix/restclient_bool_authconfigbase branch May 24, 2024 12:19
@rudolfix rudolfix restored the fix/restclient_bool_authconfigbase branch May 25, 2024 09:15
rudolfix added a commit that referenced this pull request May 25, 2024
rudolfix added a commit that referenced this pull request May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants