Docs: deploy airflow #410
Merged
Docs: deploy airflow #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rflow as separated pages.
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
adrianbr
requested changes
Jun 14, 2023
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-airflow-composer.md
Outdated
Show resolved
Hide resolved
adrianbr
approved these changes
Jun 15, 2023
rudolfix
approved these changes
Jun 15, 2023
| @@ -19,7 +19,7 @@ | |||
| from dlt.common.destination.reference import DestinationReference | |||
|
|
|||
| REQUIREMENTS_GITHUB_ACTION = "requirements_github_action.txt" | |||
| DLT_DEPLOY_DOCS_URL = "https://dlthub.com/docs/walkthroughs/deploy-a-pipeline" | |||
| DLT_DEPLOY_DOCS_URL = "https://dlthub.com/docs/walkthroughs/deploy-a-pipeline/deploy-with-github-actions" | |||
There was a problem hiding this comment.
we should have a corresponding link in our code for composer. I'll take a look in the other PR (#401 )
| @@ -45,7 +45,7 @@ dlt deploy <script>.py airflow-composer --schedule "*/30 * * * *" | |||
|
|
|||
| [Google Composer](../running-in-production/orchestrators/airflow-gcp-cloud-composer.md) is a managed Airflow deployment provided by Google. | |||
There was a problem hiding this comment.
we should link IMO to your new docs page
rudolfix
pushed a commit
that referenced
this pull request
Jun 15, 2023
* created folder deploy-a-pipeline, moved in there deploy github and airflow as separated pages. * added pages to sidebar, added title * fix link * fix link: walkthroughs/deploy-a-pipeline/deploy-with-github-actions.md * fix link: walkthroughs/deploy-a-pipeline/deploy-with-github-actions.md * fix folder deploy-a-pipeline * rename github actions deploy * delete md extension * rename title * rename title * fix code blocks * fix comma
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created folder deploy-a-pipeline, moved in there deploy github and airflow as separated pages.