Added deploy with google cloud functions #426
Conversation
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-google-cloud-functions.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
hey @dat-a-man was this cloud function running at all? because it looks like the env variable is not correctly used. but maybe I'm wrong :)
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-google-cloud-functions.md
Outdated
Show resolved
Hide resolved
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-google-cloud-functions.md
Outdated
Show resolved
Hide resolved
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-google-cloud-functions.md
Outdated
Show resolved
Hide resolved
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-google-cloud-functions.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
hey @dat-a-man please fix the PR as specified. I have working direct google secrets in mainpipelinenotion6 but I can add it when other things are fixed
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-google-cloud-functions.md
Outdated
Show resolved
Hide resolved
|
|
||
| info = pipeline.run(data) | ||
| print(info) | ||
| return "Data loaded successfully". # returns the value |
There was a problem hiding this comment.
please return str(info) instead! and yiu see a nice load info
There was a problem hiding this comment.
return str(info) is not working, its Namerror.
There was a problem hiding this comment.
tried some things earlier too, it would be nice if the function could return load_info
There was a problem hiding this comment.
Any solution to this? Please
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-google-cloud-functions.md
Outdated
Show resolved
Hide resolved
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-google-cloud-functions.md
Outdated
Show resolved
Hide resolved
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-google-cloud-functions.md
Outdated
Show resolved
Hide resolved
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-google-cloud-functions.md
Outdated
Show resolved
Hide resolved
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-google-cloud-functions.md
Outdated
Show resolved
Hide resolved
Updated according to latest comments
There was a problem hiding this comment.
Probably my previous review was not clear:
I think we should give user an option to not use the Secrets Manager at all. That was option 1 I wrote in my previous review. You can add env variable API_KEY with the right value without a need to set up permissions to secret manager. I'd offer this to the user
and what you describe in ## 3. I'd offer as option 2
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-google-cloud-functions.md
Outdated
Show resolved
Hide resolved
| - Click 'Add a secret reference' and select the secret you created, for example 'notion_secret'. | ||
| - Set the 'Reference method' to 'Mounted as environment variable'. | ||
| - In the 'Environment Variable' field, enter the name of the environment variable that corresponds to the argument required by the pipeline. - Remember to capitalize the variable name if it is required by the pipeline and specified in secrets.toml. For example, if the variable name is api_key and you have defined the value in the secrets manager secret as "notion_secret", you would declare the environment variable as "API_KEY". | ||
| - Finally, click 'DEPLOY' to deploy the function. The HTTP trigger will now successfully execute the pipeline every time the URL is triggered. |
There was a problem hiding this comment.
here the info on adding permissions to read (Secret Accessor) is actually useful :) sorry for being pedantic. but I'd like to have a good working deployment because we'll implement it in dlt core soon
There was a problem hiding this comment.
Added Sir, please see.
Added Roles to be assigned to the service account and updated format a bit.
No description provided.