detect serverless aws_lambda #490
Conversation
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
@muppinesh this looks good! thank you! would you also like to add the GCP lambda function detection. my fault was not to specified that in the ticket, now updated #474 (I was expecting to write it myself :)
|
Hi @rudolfix , Sure, I will make changes for GCP as well and update you on the progress. |
|
@rudolfix , I have made changes for GCP as well. Please merge . Let me know for any concerns. |
dlt/common/runtime/exec_info.py
Outdated
| names.append("aws_lambda") | ||
| if is_gcp_cloud_function(): | ||
| names.append("gcp_cloud_function") | ||
| return names |
There was a problem hiding this comment.
please fix indentation, now the function returns any data only if on cloud function
There was a problem hiding this comment.
Hi @rudolfix , indentation has been fixed. Please proceed.
|
This was my first proper open source contribution. Thanks for the opportunity @rudolfix . |
* adding aws lambda env checks * gcp_cloud_function * indent_correction
@rudolfix Please let me know for any concerns