788 clarify docs intro #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitting more on the intro page is more important than nice code layout.
fitting more on the intro page is more important than nice code layout.
…into 788-clarify-docs-intro
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@adrianbr . Thank you for helping through this contribution. Here's a draft PR. I appreciate feedback on the content. I won't be offended if you like the original version better. Re the CI/CD process:
|
AstrakhantsevaAA
requested changes
Dec 1, 2023
|
Yes will do in next few hours
…On Sat, 2 Dec 2023 at 1:32 am, Alena Astrakhantseva < ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In docs/website/docs/intro.md
<#797 (comment)>:
>
-How the script works?: It extracts data from a
-[source](general-usage/glossary.md#source) (here: **chess.com REST API**), inspects its structure to create a
-[schema](general-usage/glossary.md#schema), structures, normalizes and verifies the data, and then
-loads it into a [destination](general-usage/glossary.md#destination) (here: **duckdb** into a database schema **player_data** and table name **player**).
+What that code does:
+
+1. Extracts data from a
+[source](general-usage/glossary.md#source) (here: **chess.com REST API**)
could you add the dots "." at the end of sentences
1. Extracts data from a
[source.]
2. dlt inspects the data's structure to create a
[schema.]
—
Reply to this email directly, view it on GitHub
<#797 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANX27CRPJ5CWBDBU72QGQILYHHS7PAVCNFSM6AAAAABAATQ4A2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONJZHEZTONZZGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
AstrakhantsevaAA
approved these changes
Dec 4, 2023
|
@AstrakhantsevaAA , I merged the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor rewrite of the intro example
Related Issues
Additional Context
1st PR by new contributor, so some of the motivation was simply to contribute something.
It could be good to have this example (chess) as a Google Colab too. I was nicely suprised that Google Colab just works, with only a simple google account. But the static html example on intro.md is still great for people casually browsing the docs on their phone on the bus etc.